Move Activity into gks-common, and update Contribution accordingly #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the Activity class from va-spec core-im into gkscommon (because Contribution inherits from this class). Made a couple minor updates to property descriptions here.
- Updated Contribution to reference/extend Activity as needed
- state its inheritance from Activity
- define `contributor` to extend `performedBy` - so we can give a more precise definition and constrain cardinality to one Agent
- removed `contirbutionMadeTo` property - there is no real use case for it, as Contributions are always referenced from the artifacts contributed to, not the other way.
- removed `date` - as this property is now inherited from Activity.
- changed name of activity -> activityType`, to be clear that what goes here is a code representing the type of activity performed in making the contribution. For now, only one type allowed per contribution, but we may want to allow for an array here in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributorto extendperformedBy, so we can give a more precise definition and constrain cardinality to one AgentcontirbutionMadeToproperty - there is no real use case for it, as Contributions are always referenced from the artifacts contributed to, not the other way. And this avoids us needing to move InformationEntity into gks-common.date, as this property is now inherited from Activity.activity->activityType, to be clear that what goes here is a code representing the type of activity performed in making the contribution. For now, only one type allowed per contribution, but we may want to allow for an array here in the future.