Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translate_from signature + handling different from_translators #150

Closed
korikuzma opened this issue Jan 17, 2023 · 0 comments · Fixed by #152
Closed

Update translate_from signature + handling different from_translators #150

korikuzma opened this issue Jan 17, 2023 · 0 comments · Fixed by #152
Assignees
Labels
enhancement New feature or request

Comments

@korikuzma
Copy link
Contributor

The dispatch table approach is pretty clean when each translator has the same arguments, but if we need different params for different translators, I think we probably have to call them within some if/then blocks. A little inelegant but IMO cleaner than passing a bunch of unused arguments to every other function.

Originally posted by @jsstevenson in #148 (comment)

@korikuzma korikuzma added the enhancement New feature or request label Jan 17, 2023
@korikuzma korikuzma self-assigned this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant