Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logging #156

Closed
korikuzma opened this issue Feb 20, 2023 · 1 comment
Closed

Refactor logging #156

korikuzma opened this issue Feb 20, 2023 · 1 comment
Labels
Stale-exempt

Comments

@korikuzma
Copy link
Contributor 

          Libraries should not initialize logging. This should be left to applications. Unexpected or inconsistent behavior is likely with this setup. If I left this here, it must've been during debugging. Up to you whether you want to address it for this PR since it's out of scope.

Originally posted by @reece in #149 (comment)
@korikuzma
Copy link
Contributor Author

Closing. I think this is good on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale-exempt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@korikuzma