Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python versions to support #199

Closed
korikuzma opened this issue Jul 3, 2023 · 7 comments · Fixed by #200
Closed

Python versions to support #199

korikuzma opened this issue Jul 3, 2023 · 7 comments · Fixed by #200
Assignees

Comments

@korikuzma
Copy link
Contributor

In setup.cfg we specify python_requires = >= 3.6. I think we should change to python_requires = >= 3.8 since 3.7 end-of-life was 6 days ago. We should also add 3.11 to CI checks. @ga4gh/vrs-python-maintainers do you agree?

@korikuzma
Copy link
Contributor Author

@ga4gh/vr-maintainers

@ahwagner
Copy link
Member

ahwagner commented Jul 4, 2023

Yes, this sounds good to me.

@larrybabb
Copy link
Contributor

good with me too

@aniketh3014
Copy link

Hey @korikuzma, the changes that I made in my last commit in #198, were correct, or I still got it wrong?

@korikuzma
Copy link
Contributor Author

@aniketh3014 is what we need now:

python-version: ["3.8", "3.9", "3.10", "3.11"]

Decided to just do one PR since I think it's cleaner

@aniketh3014
Copy link

@korikuzma Thank you for taking the time to clarify and guide me through. I am trying to understand the code base and learn the technologies used, I truly appreciate your support.

@korikuzma
Copy link
Contributor Author

@aniketh3014 Feel free to make new issues if you have questions. We have some issues with the label good first issue if you'd like to tackle some other problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants