Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hashable BaseModel subclass in order to enforce uniqueItems with Set annotation #225

Open
theferrit32 opened this issue Aug 2, 2023 · 3 comments
Labels
2.0-alpha Issues related to VRS 2.0-alpha branch

Comments

@theferrit32
Copy link
Contributor

We just need to define what to use as the hash value that will work across all the models.

pydantic/pydantic#1303 (comment)

@ahwagner if are going to go ahead with making every object digestible in the model and serialize algorithm, that could be a good solution to this, we can just use those digests. (with a special case for custom root types with a non-pydantic type as their root, like IRI being a str)

@theferrit32 theferrit32 added the 2.0-alpha Issues related to VRS 2.0-alpha branch label Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This issue was marked stale due to inactivity.

@github-actions github-actions bot added the Stale label Oct 2, 2023
@theferrit32 theferrit32 removed the Stale label Oct 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

This issue was marked stale due to inactivity.

@github-actions github-actions bot added the Stale label Dec 5, 2023
@korikuzma korikuzma removed the Stale label Dec 5, 2023
@korikuzma
Copy link
Contributor

@theferrit32 I think this is done here. If you agree, we can close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-alpha Issues related to VRS 2.0-alpha branch
Projects
None yet
Development

No branches or pull requests

2 participants