Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex pattern to IRI class #240

Open
korikuzma opened this issue Aug 30, 2023 · 3 comments
Open

Add regex pattern to IRI class #240

korikuzma opened this issue Aug 30, 2023 · 3 comments
Labels
2.0-alpha Issues related to VRS 2.0-alpha branch bug Something isn't working Stale-exempt

Comments

@korikuzma
Copy link
Contributor

korikuzma commented Aug 30, 2023

An IRI is a reference to another object. It can be of any form under the IETF specification. When we say the sequence slot is dereferenced, it means that instead of an IRI, we have a SequenceReference object. This is true for every property in VRS where we allow for an IRI or object.

I think it is fair for us to assume this property (and every property) is dereferenced / has full object representation for normalization. We SHOULD NOT assume that an IRI takes a specific form (e.g. a refseq or ga4gh identifier) as we do here. I also believe that IRIs that contain a colon before an IRI fragment identifier (#; again, as seen here) are not valid IRIs.

Originally posted by @ahwagner in #234 (comment)

@korikuzma korikuzma added bug Something isn't working 2.0-alpha Issues related to VRS 2.0-alpha branch labels Aug 30, 2023
@github-actions
Copy link

This issue was marked stale due to inactivity.

@Rhythm1710
Copy link

Hi! Can I work on this issue?

@korikuzma
Copy link
Contributor Author

@Rhythm1710 Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-alpha Issues related to VRS 2.0-alpha branch bug Something isn't working Stale-exempt
Projects
None yet
Development

No branches or pull requests

2 participants