Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize serialize behavior for SequenceReference #341

Closed
ahwagner opened this issue Feb 6, 2024 · 2 comments
Closed

Standardize serialize behavior for SequenceReference #341

ahwagner opened this issue Feb 6, 2024 · 2 comments
Assignees
@ahwagner

Comments

@ahwagner
Copy link
Member

ahwagner commented Feb 6, 2024

Currently, SequenceReference is digested while other (non-identifiable) Value Objects are not. This should be updated so that SequenceReference behaves as a standard Value Object (see model 2 from discussion ga4gh/vrs#465).
@ahwagner ahwagner self-assigned this Feb 6, 2024
@ahwagner ahwagner mentioned this issue Feb 7, 2024
Merged
@korikuzma
Copy link
Contributor

@ahwagner can we close this since you addressed in #342?

@ahwagner
Copy link
Member Author

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahwagner ahwagner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahwagner @korikuzma