Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported Filesystem Protocols #15

Open
david4096 opened this issue Jan 18, 2018 · 5 comments
Open

Supported Filesystem Protocols #15

david4096 opened this issue Jan 18, 2018 · 5 comments

Comments

@david4096
Copy link
Member

david4096 commented Jan 18, 2018

From @kellrott

We should have a discussion about syncing this concept with the one used in TES: https://github.com/ga4gh/task-execution-schemas/blob/master/task_execution.proto#L527

@jaeddy
Copy link
Member

jaeddy commented May 2, 2019

@susheel / @delagoya — the link above is dead. Can you point me to where the concept of supported filesystem protocols (or URI schemes) is specified in TES?

@delagoya
Copy link
Contributor

It was originally pointing to the ServiceInfo result, but this was not well specified or documented. Here is the equivalent line from the JSON file, the storage attribute:
https://github.com/ga4gh/task-execution-schemas/blob/7bff83fd0120d6973f39508cc002d8e1690a0324/task_execution.swagger.json#L437

Here is a link above to the line but changed to adjust for the repo tag v.03:
https://github.com/ga4gh/task-execution-schemas/blob/d283bcb8d011c0603594daded1b28581520064f7/task_execution.proto#L527

@susheel
Copy link
Member

susheel commented May 29, 2019

@jaeddy The line below lists out the supported filesystem protocols in the new YAML spec.
https://github.com/ga4gh/task-execution-schemas/blob/d55bf880062442288afc95665aa0e21fbba77b20/openapi/task_execution.swagger.yaml#L407

@patmagee
Copy link
Contributor

@jaeddy @david4096 this seems like something we have implemented already in the service info object, just wondering if I can close this

@jaeddy
Copy link
Member

jaeddy commented Sep 22, 2022

@patmagee it's implemented, but I don't know if it's necessarily synced with whatever approach TES has adopted per @kellrott's original comment. There's also the related issue of how to capture supported_filesystem_protocols when multiple environments and layers could be part of a WES service. It might be worth consolidating both threads into a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants