Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msvc_sink pulls in windows.h even with SPDLOG_COMPILED_LIB defined #1667

Closed
Ryan-rsm-McKenzie opened this issue Sep 7, 2020 · 4 comments
Closed

msvc_sink pulls in windows.h even with SPDLOG_COMPILED_LIB defined #1667

Ryan-rsm-McKenzie opened this issue Sep 7, 2020 · 4 comments

Comments

@Ryan-rsm-McKenzie
Copy link
Contributor

Is this intentional? I know msvc_sink is a template, but it could defer to a function declaration with an implementation in a cpp file with SPDLOG_COMPILED_LIB defined.
@gabime
Copy link
Owner

gabime commented Sep 7, 2020

It could, but since it is header only sink, it is intentional.

@gabime
Copy link
Owner

gabime commented Sep 7, 2020

I wonder though if including debugapi.h instead is better.

@terraKote
Copy link

Can we omit using windows.h anyhow?

@gabime gabime closed this as completed in 62b4b7a Sep 28, 2020
@gabime
Copy link
Owner

gabime commented Sep 28, 2020 •
edited
Loading

Fixed using a trick found in SO (https://stackoverflow.com/a/30741042).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabime @terraKote @Ryan-rsm-McKenzie