-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fmt lib to v9.0.0 #2471
Comments
Note that fmt v9.0.0 deprecated automatic ostream formatting that may need additional consideration by spdlog (I'm currently evaluating spdlog v1.10.0 with fmt v9.1.0):
|
Thanks for the heads up. what additional consideration is needed? |
I'm not sure if you or your users would consider it a breaking change in spdlog if automatic ostream formatting disappears for example. |
An argument for the update is that fmt v9.x fixes a deprecation warning on newer Clang version with C++20 (fmtlib/fmt#2408). |
The old behaviour could be activated with |
Thanks for the info @SX91 ! |
Hello, @gabime ! Thanks for your reply. I think, leaving this problem to end user would break existing code, which relies on auto ostream-based formatting. If there's no other backwards incompatible changes in |
Updated to fmt version 9.1.0. Preserved for this version the deprecated ostream formatting by defining |
Hi fmt v9.0.0 has a big update and better implementation on snprintf and output. Please update it. Thanks.
The text was updated successfully, but these errors were encountered: