Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyclocomp efficiency edge case & bug #25

Open
MichaelChirico opened this issue Sep 19, 2023 · 0 comments
Open

cyclocomp efficiency edge case & bug #25

MichaelChirico opened this issue Sep 19, 2023 · 0 comments

Comments

@MichaelChirico
Copy link

MichaelChirico commented Sep 19, 2023

Here's a file where cyclocomp::cyclocomp() takes ages:

https://github.com/mwaldstein/edgarWebR/blob/fb9a38e6a57186ffd1c93cc1aa00c4fdf1bc5514/vignettes/intro/0/browse-edgar-3c23fc.R

Definitely an edge case file & should probably be excluded from linting, but we keep testing it as it gave insights to improve {lintr} performance in general. Sharing in case it highlights something similar for {cyclocomp}.

parsed_file <- parse("~/github/edgarWebR/vignettes/intro/0/browse-edgar-3c23fc.R")
system.time(cyclocomp::cyclocomp(parsed_file))
# Error in rec$last[[1]] : subscript out of bounds
# Timing stopped at: 308.1 0.064 308.3
@MichaelChirico MichaelChirico changed the title cyclocomp efficiency edge case cyclocomp efficiency edge case & bug Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant