Ember objects detected as react components

[mattijauhiainen]

react-transform seems to mistake ember objects with render method as react components. A testcase with few examples of typical syntax. Changing the method name to _render 'fixes' the test. mattijauhiainen@dbfbf5d

[nfcampos]

I'm guessing this does not do what we want?
https://github.com/babel/babel/blob/master/packages/babel-types/src/react.js#L5

Also, I'm not really familiar with developing babel plugins but if it were possible to inspect the prototype of an object it would be quite trivial to identify react components no?

[gaearon]

@nfcampos

I don’t think we use that function.
No, we can’t inspect the prototype because this is compile time, not run time.
I think the bug, if there is one, is somewhere here:

babel-plugin-react-transform/src/index.js

Lines 5 to 9 in 63cafc9

	return !!find(patterns, pattern => {
	return (
	t.isIdentifier(path.node, { name: pattern }) ||
	path.matchesPattern(pattern)
	);

[gaearon]

Or, rather, the problem is most likely that these two lines should end with || rather than &&:

babel-plugin-react-transform/src/index.js

Line 77 in 63cafc9

!matchesPatterns(path.get('superClass'), this.superClasses) &&

babel-plugin-react-transform/src/index.js

Line 122 in 63cafc9

!matchesPatterns(path.get('callee'), this.factoryMethods) &&

Please feel free to submit a fix, add tests for it, and I’ll be happy to merge.

[gaearon]

Closing as duplicate of #84. (This one is earlier but the other one describes the problem more accurately).

[gaearon]

Should be fixed in 2.0.1.