Node compatibility

[pluma]

According to React's component reference, componentWillMount will also be run on the server. This means bad things will happen (namely, it will attempt to access document on the server, which likely throws an exception).

I don't see any reason not to use componentDidMount instead.

EDIT: See PR #2 for why we can't use componentDidMount for this component.

[gaearon]

Makes sense. Would you mind sending a PR?

[pluma]

Sure. I'll try it in my prerendering+client setup and send you a PR if I get it working.

[gaearon]

Please check it doesn't break nested titles. (It shouldn't but didMount execute in different order than willMount so there could be some kind of issue)

[pluma]

Is there a particular reason you're using addons.Children.only? I can't find any documentation for it and it breaks when using divs for me. If you only want to check whether this.props.children contains more than one component, invariant(!Array.isArray(this.props.children), "error message here") should suffice.

[gaearon]

Can you give me a breaking example?

One of this component's goals is to emit zero DOM and since react doesn't support returning multiple nodes in render, I require it to have one child.

Only always worked for me for this use case.

[gaearon]

Docs: http://facebook.github.io/react/docs/top-level-api.html#react.children

(Only is last)

[gaearon]

You might have an error if you're using DT as a leaf node. It's suppose to have a child.

[pluma]

I found the problem: I was using my git working directory as a node_dependency in the project and had run npm install inside of that, so DocumentTitle was using a different copy of React than the code using it. Children.only seems to be doing identity or inheritance checks at some point, which would obviously fail. Sorry about the noise.

[gaearon]

This problem is literally chasing me.

gaearon/react-hot-loader#32 (comment)
KyleAMathews/coffee-react-quickstart#10 (comment)

I guess I'll file it as an issue in React..