Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes during server rendering #283

Closed
gaearon opened this issue May 3, 2016 · 1 comment
Closed

Crashes during server rendering #283

gaearon opened this issue May 3, 2016 · 1 comment
Labels

Comments

@gaearon
Copy link
Owner

gaearon commented May 3, 2016

reduxjs/redux-devtools@64f58b7#commitcomment-17332926
facebook/react#6689

For now, we should do something like

class AppContainer {
 ...
}

if (typeof window !== 'undefined') {
  AppContainer.prototype.unstable_handleError = ...
}
@calesce
Copy link
Collaborator

calesce commented Oct 16, 2016

Closing this since the original React issue was fixed. I've also tested rendering <AppContainer /> on the server and it doesn't crash (even though most people will only need to use it in the client bundle)

@calesce calesce closed this as completed Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants