Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my components keeps mounting. #336

Closed
aalpgiray opened this issue Aug 4, 2016 · 2 comments
Closed

my components keeps mounting. #336

aalpgiray opened this issue Aug 4, 2016 · 2 comments

Comments

@aalpgiray
Copy link

no meter what I tried i couldn't be able to hot replace my code without unmounting the react components, so

componentWillUnmount() { alert('I knew Dan lied about hot reloading.'); },

keeps firing,

I know i did something wrong but what?

here is the repository i put together ,

https://github.com/aalpgiray/react-redux-typescript.git

@calesce
Copy link
Collaborator

calesce commented Sep 7, 2016

This might not be the only issue, but I do see that you use decorators, and decorated components currently don't hot reload (#279).

@aalpgiray
Copy link
Author

I have edited the official boilerplate. Now everything works.

typescript react-redux-hot-reload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants