Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support es6 modules #909

Closed
pdeva opened this issue Mar 26, 2018 · 1 comment
Closed

Support es6 modules #909

pdeva opened this issue Mar 26, 2018 · 1 comment

Comments

@pdeva
Copy link

pdeva commented Mar 26, 2018

The documentation says that es6 will not work.
We have switched to generating es6 modules from typescript.
going back to commonjs seems like a step backward.

Please add support for es6 modules in hot-loader 4
@theKashey
Copy link
Collaborator

That's a typo. ES5 will not work :), and only in case of TS.

theKashey added a commit that referenced this issue Mar 30, 2018
@theKashey
better typescript playbooks. #884 #909
d3b91de
@theKashey theKashey mentioned this issue Mar 30, 2018
Merged
gregberge added a commit that referenced this issue Mar 30, 2018
@gregberge
docs(readme): better typescript playbooks
8c09378 
Closes #884
Closes #909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregberge @theKashey @pdeva