This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
add json rpc bindings for eth_getCode #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hello @gakonst. I have just started browsing through this repository, trying to understand the implementation structure.
While doing this and getting my local machine setup, I found a
TODOin the provider's JSON RPC bindings, and it was a quick way to get up and running.I am exploring the issues you've added, and hopefully I can take up some of them.
Solution
The addition is quite similar to
get_balanceorget_transaction_count. I am not sure if the lines I added inethers/src/lib.rsadd any value, because the existing docs forget_blockalready solve that purpose.