Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix(providers): use middleware associated err type #2093

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix(providers): use middleware associated err type #2093

merged 1 commit into from
Jan 30, 2023

Conversation

Rjected
Copy link
Contributor

@Rjected Rjected commented Jan 30, 2023

Motivation

Some methods in Middleware were using ProviderError rather than the associated error type.

Solution

Change the following methods on Middleware to use Self::Error instead of ProviderError:

  • import_raw_key
  • unlock_account
  • debug_trace_transaction
  • debug_trace_call

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

@Rjected Rjected changed the title feat(core): use middleware associated err type fix(providers): use middleware associated err type Jan 30, 2023
@Rjected Rjected mentioned this pull request Jan 30, 2023
Merged
18 tasks
@gakonst gakonst merged commit 08514ea into gakonst:master Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @gakonst