This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(provider): Add Send trait bound to PendingTx state future #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* chore: cargo +nightly fmt * chore: fix clippy lints * ci: run nightly fmt * docs: add info about formatting * ci: run nightly clippy * chore: fix clippy lints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As @roynalnaruto pointed out, the PendingTransaction struct was not Send. Reproduced with https://gist.github.com/roynalnaruto/e9424d8917eaf330d8317d19328586b5#file-sample-rs-L34. This happens because the
BinPoxFuttrait object was not limited to beSend(which it should be ).Solution
Add a
Sendtrait bound.