This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(contract, abigen): support artifact format in proc macro #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shekhirin this LGTM - there seems to be some ABI parsing failure inside the WASM tests, mind taking a look? |
|
@gakonst oh I see. Will look into it, yep. |
shekhirin
force-pushed
the
fix-abigen-proc-macro
branch
from
3978fbd to
fd58584
Compare
|
@gakonst done |
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* If cargo not installed, install to /usr/local/bin * Add comment about rm'ing old installations * forgeup -> foundryup and use a new .foundry dir structure * check PATH correctly * fix typos in README
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #476 once again, since #478 didn't solve the issue with
abigen!proc macro.Solution
Make a best-effort coercion of an ABI or an artifact JSON into an artifact JSON (idea from https://github.com/gnosis/ethcontract-rs/blob/5db6ad486256abac7509193649b7bc0f5ed40f96/ethcontract-generate/src/source.rs#L246).