This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(solc): Multiple Solc Version detection #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Nov 2, 2021
Comment on lines
+102
to
+105
| #[cfg(not(all(feature = "svm", feature = "async")))] | ||
| { | ||
| self.compile_with_version(&self.solc, sources) | ||
| } |
There was a problem hiding this comment.
should this be also configureable via some Project settings flag?
There was a problem hiding this comment.
I don't think so? Isn't it always better to support auto-detection, if you are OK with the extra dependencies?
There was a problem hiding this comment.
you're right, that's better!
mattsse
reviewed
Nov 2, 2021
Comment on lines
+102
to
+105
| #[cfg(not(all(feature = "svm", feature = "async")))] | ||
| { | ||
| self.compile_with_version(&self.solc, sources) | ||
| } |
There was a problem hiding this comment.
you're right, that's better!
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We port over the logic for detecting and automatically using the right solc version from dapptools-rs solc, leveraging the SVM and Async features. If these features are disabled, no automatic solc detection will be done, and it will use the solc version as defined in
ethers_solc::Solc's rules.