This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(core): serialize filters properly and always rewake #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
reviewed
Aug 28, 2020
gakonst
force-pushed
the
fix/serialize-topics
branch
from
9536aa2
to
f296443
Compare
gakonst
changed the title
gakonst
force-pushed
the
fix/serialize-topics
branch
from
6a4a312
to
d7bc546
Compare
gakonst
force-pushed
the
fix/serialize-topics
branch
from
d7bc546
to
9e83671
Compare
gakonst
force-pushed
the
fix/serialize-topics
branch
from
9e83671
to
7ecdd3c
Compare
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #51
Solution
Previously it'd serialize to
["0x123", null, null, null]which is not spec-compliant behavior. Now we serialize according to the spec. In addition we always re-wake to avoid getting stuck in the reactor's multithreaded eloop