Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

chore(solc): also rm cache dir if empty #822

Merged
merged 1 commit into from
Jan 21, 2022
Merged

chore(solc): also rm cache dir if empty #822

merged 1 commit into from
Jan 21, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 20, 2022

Motivation

followup #820
Ref foundry-rs/foundry#322 (comment)

Solution

if the cache file was the only file in the dir, remove the parent dir (./cache/) as well

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

gakonst
gakonst approved these changes Jan 21, 2022
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - note that if we intend changing the caching format we'll need to adjust this logic too

@gakonst gakonst merged commit f9fadf0 into gakonst:master Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @gakonst