fix(solc): use nodesiter when printing tree #878

mattsse · 2022-02-07T15:13:47Z

Motivation

prevent possible SO when construction import tree

Solution

use existing NodesIter to determine error msg like

   0: Discovered incompatible solidity versions in following
      : src/MyContract.sol (^0.8.0) imports:
          lib/yearn-vaults/contracts/BaseStrategy.sol (>=0.6.0 <0.7.0) 
          lib/yearn-vaults/contracts/BaseStrategy.sol (>=0.6.0 <0.7.0)

PR Checklist

Added Tests
Added Documentation
Updated the changelog

gakonst · 2022-02-07T16:26:25Z

ethers-solc/src/resolver.rs

@@ -661,6 +654,18 @@ struct SolData {
    version_req: Option<VersionReq>,
 }

+impl SolData {
+    fn fmt_version<W: std::fmt::Write>(


Any idea why this throws warning?

guess unused in wasm

fix(solc): use nodesiter when printing tree

35b0a04

mattsse force-pushed the matt/fix-so-in-format-tree branch from 73e2217 to 35b0a04 Compare February 7, 2022 15:43

gakonst approved these changes Feb 7, 2022

View reviewed changes

gakonst merged commit a0568fe into gakonst:master Feb 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(solc): use nodesiter when printing tree #878

fix(solc): use nodesiter when printing tree #878

mattsse commented Feb 7, 2022 •

edited

Loading

gakonst Feb 7, 2022

mattsse Feb 7, 2022

fix(solc): use nodesiter when printing tree #878

fix(solc): use nodesiter when printing tree #878

Conversation

mattsse commented Feb 7, 2022 • edited Loading

Motivation

Solution

PR Checklist

gakonst Feb 7, 2022

Choose a reason for hiding this comment

mattsse Feb 7, 2022

Choose a reason for hiding this comment

mattsse commented Feb 7, 2022 •

edited

Loading