This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
refactor: extract minimal features of Contract into BaseContract #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pawanjay176 added some changes on top, also working on a human readable ABIs, will have something tomorrow |
|
Thanks @gakonst. Also started working on the human readable abis. I'm doing plain parsing something similar to this https://gist.github.com/pawanjay176/4340020c41898cfee7d0430538cee986 The biggest issue with this approach is parsing the function/event arguments since it may contain solidity tuples. I was able to extend the above gist to handle all types of arguments, but the resulting code is incredibly ugly and doesn't handle many of the edge cases. If you could share your approach, I can try and finish up the code for it :) |
gakonst
force-pushed
the
contract-refactor
branch
from
e9ec68f to
0272337
Compare
3 tasks
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* fix(fuzz): own the fuzzer to avoid soundness issues Apparently some functions would not get fuzzed in certain cases when using the RefCell pattern * fix(fuzz): snapshot and reset to original state before each run * feat: expose call with serializing & without deserializing * fix: ensure check_success works correctly * test: add CheatCodes.sol * test: fuzz test all fns in cheatcodes file * chore: update sputnik to latest branch commit * fix: make dapp runner require Clone
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #80
Solution
Refactors the
Contractstruct by extracting theabiinto aBaseContractstruct which does only abi encoding.Working on adding human-readable abis.