Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.2] release testing - UI tests for new workflow parameters #19182

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[24.2] release testing - UI tests for new workflow parameters #19182

merged 1 commit into from
Nov 27, 2024

Conversation

jmchilton
Copy link
Member

Bug fix - missing tests.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. GALAXY_TEST_SELENIUM_USER_EMAIL="<main_login>" GALAXY_TEST_SELENIUM_USER_PASSWORD="<main_password>" GALAXY_TEST_EXTERNAL=https://usegalaxy.org/ GALAXY_TEST_SCREENSHOTS_DIRECTORY=screens pytest -s lib/galaxy_test/selenium/test_workflow_editor.py::TestWorkflowEditor::test_float_parameter_maximum_validation

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton marked this pull request as ready for review November 21, 2024 23:50
@github-actions github-actions bot added this to the 25.0 milestone Nov 21, 2024
@jmchilton jmchilton requested a review from mvdbeek November 27, 2024 16:02
mvdbeek
mvdbeek approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@mvdbeek mvdbeek merged commit 2f7c1e5 into galaxyproject:release_24.2 Nov 27, 2024
52 of 54 checks passed
@jdavcs jdavcs modified the milestones: 25.0, 24.2 Dec 4, 2024
@jmchilton jmchilton added the release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/testing/selenium area/UI-UX kind/bug release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jmchilton @mvdbeek @jdavcs