Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Fix workflow report time handling #19292

Open
wants to merge 14 commits into
base: release_24.2
Choose a base branch
from

Conversation

dannon
Copy link
Member

@dannon dannon commented Dec 9, 2024

Fixes #19184, and consolidates handling (our 'Z'-appending hack) of galaxy timestamps. They are also now consistent with the 'pretty' format we use in the rest of the application. Adds some tests.

After:

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.0 milestone Dec 9, 2024
@dannon dannon force-pushed the fix-invocation-time branch from 6996a8d to 83f06ee Compare December 9, 2024 19:05
@dannon
Copy link
Member Author

dannon commented Dec 9, 2024

Looks like neither way I am trying to fake a timezone for jest have worked, still tinkering...

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the unified handling! Much better now!

@dannon dannon force-pushed the fix-invocation-time branch from bdce81c to 5870f7b Compare December 10, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants