-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.2] Fix workflow report time handling #19292
Open
dannon
wants to merge
14
commits into
galaxyproject:release_24.2
Choose a base branch
from
dannon:fix-invocation-time
base: release_24.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+115
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannon
force-pushed
the
fix-invocation-time
branch
from
December 9, 2024 19:05
6996a8d
to
83f06ee
Compare
Looks like neither way I am trying to fake a timezone for jest have worked, still tinkering... |
davelopez
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the unified handling! Much better now!
…at and allowing clients to localize
…ate formatGalaxyPrettyDateString to use the new function for improved localization.
…r improved date handling and formatting
…puts. Minor cleanup.
…or raw isoformat in the two different export formats.
dannon
force-pushed
the
fix-invocation-time
branch
from
December 10, 2024 12:48
bdce81c
to
5870f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19184, and consolidates handling (our 'Z'-appending hack) of galaxy timestamps. They are also now consistent with the 'pretty' format we use in the rest of the application. Adds some tests.
After:
How to test the changes?
(Select all options that apply)
License