Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Don't show published workflows in workflow activity of workflow editor #19312

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Dec 11, 2024

If we want to do this we need to separate owned and published, then make a new copy or reference as we insert the public workflow. As it stands you won't be finding your own workflows, since the public workflows are far more numerous then any one user's workflows.

Fixes #19265

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

If we want to do this we need to separate owned and published, then make
a new copy or reference as we insert the public workflow. As it
stands you won't be finding your own workflows, since the public
workflows are far more numerous then any one user's workflows.

Fixes galaxyproject#19265
@github-actions github-actions bot added this to the 25.0 milestone Dec 11, 2024
@davelopez
Copy link
Contributor

Should target 24.2? or is this intentionally targeting dev?

@mvdbeek mvdbeek changed the title Don't show published workflows in workflow activity of workflow editor [24.2] Don't show published workflows in workflow activity of workflow editor Dec 11, 2024
@mvdbeek mvdbeek changed the base branch from dev to release_24.2 December 11, 2024 14:12
@mvdbeek
Copy link
Member Author

mvdbeek commented Dec 11, 2024

Oops, yep, changed the branch now

@jmchilton jmchilton merged commit 41ade9f into galaxyproject:release_24.2 Dec 12, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow: Problems with inserting another workflow as a sub-workflow on the editor canvas
3 participants