Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-built binaries for Electron 3 #344

Open
rbeeger opened this issue Nov 12, 2018 · 6 comments
Open

Pre-built binaries for Electron 3 #344

rbeeger opened this issue Nov 12, 2018 · 6 comments

Comments

@rbeeger
Copy link
Contributor

rbeeger commented Nov 12, 2018

Please add pre-built binaries for Electron 3.
@galkahana
Copy link
Owner

cheers.

hhaidar added a commit to hhaidar/HummusJS that referenced this issue Nov 16, 2018
@hhaidar
add electron 3 build
aab05f2 
Ref galkahana#344
@hhaidar hhaidar mentioned this issue Nov 16, 2018
Merged
hhaidar added a commit to hhaidar/HummusJS that referenced this issue Nov 16, 2018
@hhaidar
add electron 3 build
6173aa9 
Ref galkahana#344
@hhaidar
Copy link
Contributor

hhaidar commented Nov 16, 2018 •
edited
Loading

I've opened a PR for this.

@galkahana electron v4 is coming out soon too, it might make sense to drop support for v1.

hhaidar added a commit to hhaidar/HummusJS that referenced this issue Nov 16, 2018
@hhaidar
add electron 3 build
ff1d49a 
Ref galkahana#344
hhaidar added a commit to hhaidar/HummusJS that referenced this issue Nov 16, 2018
@hhaidar
add electron 3 build
a70911b 
Ref galkahana#344
hhaidar added a commit to hhaidar/HummusJS that referenced this issue Nov 16, 2018
@hhaidar
add electron 3 build
9fe2a47 
Ref galkahana#344
@galkahana
Copy link
Owner

@hhaidar let's drop 1 once 4 gets out. makes sense?

@hhaidar
Copy link
Contributor

hhaidar commented Nov 16, 2018

@galkahana for sure!

...and it looks like my build is failing :<

/home/travis/.nvm/versions/node/v10.2.0/bin/node: symbol lookup error: /home/travis/build/galkahana/HummusJS/binding/hummus.node: undefined symbol: _ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEENS_5LocalIS4_EENSA_INS_9SignatureEEEiNS_19ConstructorBehaviorE
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.

this might not be as easy I thought haha

@galkahana
Copy link
Owner

yeah. this is the error i saw on linux/mac. see here - https://travis-ci.org/galkahana/HummusJS/builds/456039328 - in allowed failures.

the windows one goes ok - https://ci.appveyor.com/project/galkahana/hummusjs/builds/20358304

@galkahana galkahana mentioned this issue Dec 2, 2018
Open
@julianhille
Copy link
Contributor

#410 might solve these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@galkahana @rbeeger @julianhille @hhaidar