-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test_dust_pysm3 test test_d10_vs_d11 on Mac OS #121
Comments
I assume you are using the do the test pass on your machine with no modification of the code? |
I'm currently running the tests with the values for Before I made any changes to the code, the tests were not all passing. Each modification I made, I would revert before trying something different. I followed the steps on https://pysm3.readthedocs.io/en/latest/index.html#installation for Development Install. I initially was failing almost all of the tests after using Without changing anything, I now consistently pass 84 tests (2 are skipped, test_dust_pysm3/test_d10_vs_d11 fails pretty regularly, and test_synch_pysm/test_s6_vs_s5 fails sporadically, but much less frequently than test_d10_vs_d11). |
ok, let's focus for now exclusively on running without any modification of the code. |
monicahicks@DNa80dc9e pysm % pytest pysm3/tests/test_ame.py .. [ 2%] ================================================================================================ FAILURES ================================================================================================
pysm3/tests/test_dust_pysm3.py:101: actual = <Quantity [[66.72681 , 66.40845 , 66.58324 , ..., 77.87121 ,
E AssertionError: /Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/astropy/tests/helper.py:457: AssertionError pysm3/tests/test_dust_pysm3.py::test_d10_vs_d11 pysm3/tests/test_dust_pysm3.py::test_d10_vs_d11 pysm3/tests/test_dust_pysm3.py::test_d10_vs_d11 pysm3/tests/test_dust_pysm3.py::test_d10_vs_d11 -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html |
the test is
|
@bthorne93 , it would be useful if you can try on your Mac OS machine, either pip installing the |
I activated testing on Mac OS in Github Actions, see #122, tests are passing there: https://github.com/galsci/pysm/runs/7158561564?check_suite_focus=true @MonicaHicks does your machine have the M2 CPU? |
I have Intel i9. I can replicate the above results on my other MacBook, but I believe the test you ran skipped What I was planning to try next is to ssh into the Sherlock research cluster and see if I have any success running on the virtual machines. I am going to attend a workshop to get set up on the machines this Wednesday. |
You're right. I forgot I implemented that. |
Just double-checked that running it on Linux (on Jupyter@NERSC) worked fine, I was worried I could have introduced a bug without noticing affecting also Linux:
|
Okay, great. I'm confident I can get Linux running on my Mac. |
Unfortunately I had to disable the Github Actions tests on Mac OS due to some issues with Anyway let's keep this open for reference, if someone with a MAC OS with lots of ram would like to investigate, please do and provide feedback. |
I am failing test_d10_vs_d11 when passing the parameters for
seeds
andsynalm_lmax
in test_dust_pysm3.py; however, when I followed the instructions to modify data/presets.cfg and I commented out the parametersseeds
andsynalm_lmax
in the call to ModifiedBlackBodyRealization, the test passed the first time, and then began failing sporadically..I am on a MacBook Pro with python 3.9.1 and Big Sur OS.
I sometimes use Ctrl-C as a keyboard interrupt to early abort the test once I test_dust_pysm3 has completed; I don't know if this has any effect on the tests.
Before changing the configuration, the most common failure result was:
E AssertionError:
E Not equal to tolerance rtol=1e-05, atol=0.05
E
E x and y nan location mismatch:
E x: array([[66.72681 , 66.40845 , 66.58324 , ..., 77.87121 , 78.91874 ,
E 79.840225],
E [ 0.893474, -0.87911 , 0.884476, ..., 1.52126 , -1.485077,...
E y: array([[72.38888 , 70.338099, 73.356715, ..., 61.686455, 69.655437,
E 73.51729 ],
E [ 0.96929 , -0.931131, 0.974453, ..., 1.205081, -1.310762,...
After switching the configuration, the values of the matrices upon failure varied widely (sometimes all nan, sometimes with a value y[0][0] > 200).
Before switching the configuration, I tried:
output_d11 = output_d10
(this was an early sanity check to make sure it could pass)from .. import units as u
tofrom astropy import units as u
(to address warning associated withu.GHz
)tox -e test
d11
andoutput_d11
to beoutput_d11 = pysm3.models.ModifiedBlackBodyRealization( nside=nside, seeds=[8192,777,888], synalm_lmax=16384, **d11_configuration ).get_emission(freq)
The above list is non exhaustive, just examples of the types of changes I tried.
The text was updated successfully, but these errors were encountered: