Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive in rosetta stone pattern matching #18

Open
TannerRogalsky opened this issue Jun 12, 2014 · 2 comments
Open

False positive in rosetta stone pattern matching #18

TannerRogalsky opened this issue Jun 12, 2014 · 2 comments

Comments

@TannerRogalsky
Copy link

Hey Paul! I found a small bug in the pattern translation code. I think that the first ROSETTA_STONE entry is matching hyphens when it shouldn't be and turning a pattern like ^(%d+)-(%d+)$ into ^(\d+)*?(\d+)$.

'([^a-zA-Z0-9%(])-': '$1*?',

@paulcuth
Copy link
Contributor

Cheers, Tanner. The regex translation is a tricky part of the VM. I'll take a look.

@TannerRogalsky
Copy link
Author

Haha, as regexes can sometimes be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants