-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
You just killed the accessibility! #434
Comments
We've been looking at working Tiny Slider into our WordPress starter theme at WebDevStudios. One of the pain points of a lot of carousels we've tested is accessibility and the issue with trying to tab through a site and not break or get stuck in a carousel. We had the same issue you and others noted where tabbing through slides with links/buttons in them just kind of broke everything visually. In this update in a yet-to-be-reviewed PR (WebDevStudios/wd_s#481 (comment)) I've added some JS to do the following:
It's a first pass so it can likely be cleaned up and I want to do some stress testing, but in my tests thus far it's allowing me to tab through ONLY the active slide and not get caught up in the never-ending tab madness. It sets the links/buttons in inactive slides to Wanted to share it as it sounds like we were fighting the same issue and I thought it might be of some help to you and others! |
Check out #4 |
@ganlanyuan yeah you're right. I was tricked by |
Issue description: I've no idea why you add the "tabindex" attribute to everything. It's too bad! You just killed keyboard navigation...
The text was updated successfully, but these errors were encountered: