Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hostpath storageclass and csi drivers #27

Closed
wants to merge 1 commit into from

Conversation

rootfs
Copy link
Contributor

@rootfs rootfs commented Aug 30, 2020

/area control-plane
/area storage
/priority normal
/platform kubevirt

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #26

Special notes for your reviewer:

Release note:


@rootfs rootfs requested a review from a team as a code owner August 30, 2020 19:19
@gardener-robot gardener-robot added area/control-plane Control plane related area/storage Storage related platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure priority/normal labels Aug 30, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 30, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 30, 2020
Signed-off-by: Huamin Chen <hchen@redhat.com>
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 30, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 30, 2020
Copy link
Contributor

@stoyanr stoyanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid this PR has currently two many open questions / issues. Instead of commenting on individual lines, I would like to outline them here as basis for discussion.

For all this reasons, I would not reject this change, but I would ask not to continue working on it until we have decided that we definitely needed, and if this is the case, also discussed the aspects above to ensure that it's added in a way that is both configurable and consistent with other provider extensions.

@rootfs rootfs closed this Sep 2, 2020
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related area/storage Storage related needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shoot storage options via CSI drivers
6 participants