Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying userData and networkData as part of the worker config #69

Open
stoyanr opened this issue Sep 30, 2020 · 0 comments
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure priority/5 Priority (lower number equals higher priority)

Comments

@stoyanr
Copy link
Contributor

stoyanr commented Sep 30, 2020

Currently, Kubevirt VM userData is configured using a sophisticated mechanism in which multiple extensions participate. networkData is hardcoded in https://github.com/gardener/machine-controller-manager-provider-kubevirt to the following YAML snippet if custom networks are used, and to an empty string otherwise:

version: 2
ethernets:
  id0:
    match:
      name: "e*"
    dhcp4: true

We should be able to specify user-defined parts of the userData and the networkData in the Shoot resource as part of the worker config, as it could be used to configure other aspects beyond what is already configured that could be important in certain cases. See Cloud config examples and Networking Config Version 2 for the full documentation.

The contents of userData and networkData specified by the user should be merged with the already computed / default configurations. TODO How should conflicts be resolved?

Example Shoot resource with userData and networkData configured:

spec:
  provider:
    type: kubevirt
    workers:
    - name: worker1
      ...
      providerConfig:
        apiVersion: kubevirt.provider.extensions.gardener.cloud/v1alpha1
        kind: WorkerConfig
        userData: |
          <...>
        networkData: |
          <...>

/area networking
/kind enhancement
/priority normal
/platform kubevirt

@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure priority/normal labels Sep 30, 2020
@stoyanr stoyanr changed the title Add support for specifying networkData as part of the worker config Add support for specifying userData and networkData as part of the worker config Oct 9, 2020
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Dec 16, 2020
@gardener-robot gardener-robot added priority/5 Priority (lower number equals higher priority) and removed priority/nonessential labels Mar 8, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure priority/5 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

2 participants