Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Provider-specific webhooks in Garden cluster #407

Closed
1 of 10 tasks
rfranzke opened this issue Nov 1, 2019 · 1 comment
Closed
1 of 10 tasks

Provider-specific webhooks in Garden cluster #407

rfranzke opened this issue Nov 1, 2019 · 1 comment

Comments

@rfranzke
Copy link
Contributor

rfranzke commented Nov 1, 2019

With the new core.gardener.cloud/v1alpha1.Shoot API Gardener does no longer understand the provider-specifics, e.g., the infrastructure config, control plane config, worker config, etc.
This allows end-users to harm themselves and create invalid Shoot resources the Garden cluster. Errors will only become present during reconciliation part creation of the resource.

Also, it's not possible to default any of the provider specific sections. Hence, we could also think about mutating webhooks in the future.

As we are using the controller-runtime maintained by the Kubernetes SIGs it should be relatively easy to implement these webhooks as the library abstracts already most of the things.

We should have a separate, dedicated binary incorporating the webhooks for each provider, and a separate Helm chart for the deployment in the Garden cluster.

Similarly, the networking and OS extensions could have such webhooks as well to check on the providerConfig for the networking and operating system config.

  • Validating webhooks:

    • Alicloud
    • AWS
    • Azure
    • GCP
    • OpenStack
  • Mutating webhooks:

    • Alicloud
    • AWS
    • Azure
    • GCP
    • OpenStack

Part of gardener/gardener#308

@rfranzke
Copy link
Contributor Author

rfranzke commented Feb 4, 2020

Replaced with individual issues in dedicated provider repositories.
/close

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants