-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extended resources and ephemeral-storage for scale-from-zero specified in MachineClass NodeTemplate #334
Support extended resources and ephemeral-storage for scale-from-zero specified in MachineClass NodeTemplate #334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. some changes requested.
Corrected issues. Will test scale from zero for ephemeral storage and custom resources and add manual test-log tomorrow. I am unsure how to code an integration test for this though. |
Test log for scale from zero with custom resource named apiVersion: v1
kind: Pod
metadata:
name: testexres1
spec:
containers:
- name: example-container
image: busybox
command: ["sh", "-c", "echo Using extended resources && sleep 3600"]
resources:
limits:
resource.com/dongle: 2
requests:
resource.com/dongle: 2 Node Group providerConfig:
apiVersion: aws.provider.extensions.gardener.cloud/v1alpha1
kind: WorkerConfig
nodeTemplate:
capacity:
cpu: 8
ephemeral-storage: 50Gi
gpu: 0
hana.hc.sap.com/hcu/cpu: 20
hana.hc.sap.com/hcu/memory: 10
memory: 7Gi
resource.com/dongle: 6
Scale from zero triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
db938d5
into
gardener:machine-controller-manager-provider
Looking forward to using this feature - thanks! |
…specified in MachineClass NodeTemplate (gardener#334) * support extended resouces and ephemeral-storage in scale-from-zero * corrected resource issues * adjusted unit test TestBuildNodeFromTemplate for changes
What this PR does / why we need it:
Right now in scale-from-zero cases, the autoscaler does not respect ephemeral-storage and extended resource specified in the
MachineClass.NodeTemplate
. Only the standardcpu
,gpu
andmemory
are picked up. Neither is there any support for custom extended resource which are fully ignored presently.Which issue(s) this PR fixes:
Fixes #132
Special notes for your reviewer:
Release note: