Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Etcd ConfigMap changes #717

Open
3 tasks
unmarshall opened this issue Oct 27, 2023 · 3 comments · May be fixed by #812
Open
3 tasks

☂️ Etcd ConfigMap changes #717

unmarshall opened this issue Oct 27, 2023 · 3 comments · May be fixed by #812
Assignees
Labels
kind/enhancement Enhancement, improvement, extension
Milestone

Comments

@unmarshall
Copy link
Contributor

unmarshall commented Oct 27, 2023

One ConfigMap is created per etcd (etcd-main and etcd-events) today. We propose to do/relook at the following:

@unmarshall unmarshall added the kind/enhancement Enhancement, improvement, extension label Oct 27, 2023
@ishan16696
Copy link
Member

initial-advertise-peer-urls and advertise-client-urls uses @ as delimiter. This is not really required. Have proper URLs.

open issue for this point: #476

@shreyas-s-rao
Copy link
Contributor

/assign @anveshreddy18

@ishan16696
Copy link
Member

ishan16696 commented Jul 22, 2024

Make snapshot-count configurable See impact here. We can retain the default of 75000. Upstream default changes from 10000 to 100,000. We can revisit the current default if need be.

Increasing the default snapshot-count to 100K is not good as it will leads to more usage of memory.
kubeadm uses snapshot-count set to 10k. https://github.com/kubernetes/kubernetes/blob/release-1.20/cmd/kubeadm/app/phases/etcd/local.go#L270
Upstream etcd have also changed the default value of snapshot-count to 10k etcd-io/etcd#15408. They will bring this change in etcd v3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment