Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for internal/[heath, store] package were not run and needs fixing #821

Closed
unmarshall opened this issue Jun 28, 2024 · 0 comments · Fixed by #822
Closed

Tests for internal/[heath, store] package were not run and needs fixing #821

unmarshall opened this issue Jun 28, 2024 · 0 comments · Fixed by #822
Labels
area/testing Testing related kind/bug Bug status/closed Issue is closed (either delivered or triaged)

Comments

@unmarshall
Copy link
Contributor

How to categorize this issue?
/area testing
/kind bug

What happened:
In make test target two packages internal/health and internal/store were missed out. When unit tests for internal/health were explicitly run the tests did not pass. This issue is to fix the tests and include them into the make test target.

What you expected to happen:
All unit tests should be included and run successfully.
@gardener-robot gardener-robot added area/testing Testing related kind/bug Bug labels Jun 28, 2024
@unmarshall unmarshall mentioned this issue Jul 1, 2024
Merged
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Testing related kind/bug Bug status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and include unit tests for health package unmarshall/etcd-druid
2 participants
@unmarshall @gardener-robot