Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align target unset command #115

Open
grolu opened this issue Feb 18, 2022 · 1 comment
Open

Align target unset command #115

grolu opened this issue Feb 18, 2022 · 1 comment
Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@grolu
Copy link
Contributor

grolu commented Feb 18, 2022

Currently we have a target unset command while other commands (env) have a -u flag to do the unset.
We should align this.
Moreover, the target unset command currently has no subcommands but uses the target kind as argument. This is also not consistent.

I vote for introducing an unset flag for this command, too. We could deprecate the unset command and eventually remove it. Or, if we change it bevor the initial release we could also think about removing it immediately.
@grolu grolu added component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension labels Feb 18, 2022
@grolu grolu changed the title Align unset command Align target unset command Feb 18, 2022
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Aug 18, 2022
@petersutter
Copy link
Contributor

related issue #85 (second task)

@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petersutter @grolu @gardener-robot