-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target history #133
Comments
I am interested to do this task. the apprach probably similar from previous hisotry PR in gardenctl-v1 gardener-attic/gardenctl#512 use one thing I like to change this time, proposal use native history file |
Hi @tedteng, I don't think it will be a good idea to use the shell history for this purpose. You wouldn't be able to reconstruct the target without huge interpretation effort, as you won't necessarily have the target always fully qualified (e.g. We need to have the history in a structured format that we have under our control. What I'm not sure about is if the user wants to have the history only for the current session, or globally, or even both options. Btw. |
I would also argue against the shell's history: it's a super unstructured interface, e.g. I use a very short alias for targeting: Regarding session vs. global history: I think globally is more important but +1 on configurable :) (you could however bind the default to the shell's default, e.g. for zsh ohmyzsh/ohmyzsh#2537 (comment), but that's probably overenginering and not really required :) ) |
Thanks for the feedback. gather information will in the development later.
|
My gut feeling is to have separate files (gardenctl home dir vs session dir) I wouldn't want to build a feature on a library that is not maintained anymore. |
/assign Today, after rethinking about gardenctl home dir vs session dir. I'm planning to use global history unless there are some solutions we can handle session-id history, or separate tickets if the feature is needed and describe the use case. from my previous experience, it seems doesn't make sense in reality when I use the v1 history feature for session dir/file. because we never have the same session id when a new terminal window opens, then the session history is always piece by piece saved in tons of different session folders, and never used by the target history command. unless terminal windows are not closed probably interactive history records use/evaluate library by fuzzy |
History feature ready for review in PR #162 |
What would you like to be added:
It should be possible to see the target history, similar to the feature in gardener/gardenctl
Why is this needed:
The text was updated successfully, but these errors were encountered: