Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt the deployment priorityClassName according to the gardener documentation #103

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Adapt the deployment priorityClassName according to the gardener documentation #103

merged 1 commit into from
Jul 22, 2022

Conversation

krgostev
Copy link
Contributor

@krgostev krgostev commented Jul 6, 2022 •
edited
Loading

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
This PR removes the old PriorityClass from the charts and adapt the deployment priorityClassName according to the gardener documentation. Part of #5634
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

This version of gardener-extension-networking-cilium requires Gardener v1.50+.

@krgostev krgostev requested review from a team as code owners July 6, 2022 10:56
@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 6, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 6, 2022
@krgostev krgostev mentioned this pull request Jul 6, 2022
Closed
35 tasks
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 6, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 6, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 6, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 6, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 6, 2022
DockToFuture
DockToFuture reviewed Jul 11, 2022
View reviewed changes
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduling.k8s.io/v1 is also used under:

  • charts/internal/cilium/charts/utils-templates/templates/_versions.tpl
  • charts/internal/cilium-monitoring/charts/util-templates/templates/_versions.tpl

Shouldn't this be removed as well?

@DockToFuture DockToFuture mentioned this pull request Jul 11, 2022
Merged
@krgostev
Copy link
Contributor Author

I don't see scheduling.k8s.io/v1 to be used anywhere else in the project.

ScheererJ
ScheererJ reviewed Jul 15, 2022
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs a rebase.

@DockToFuture
Copy link
Member

I don't see scheduling.k8s.io/v1 to be used anywhere else in the project.

You are right it was a symlink. 👍

@ScheererJ ScheererJ added the needs/rebase Needs git rebase label Jul 15, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 21, 2022
@krgostev krgostev removed the needs/rebase Needs git rebase label Jul 21, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 21, 2022
DockToFuture
DockToFuture approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 22, 2022
@DockToFuture DockToFuture merged commit 5849abb into gardener:master Jul 22, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ left review comments

@DockToFuture DockToFuture DockToFuture approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@krgostev @DockToFuture @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot