Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set --gardenlet-uses-gardener-node-agent=true by default #111

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area os
/kind enhancement
/os ubuntu

What this PR does / why we need it:
Set --gardenlet-uses-gardener-node-agent=true by default (even when UseGardenerNodeAgent is not provided via .Values.gardener.gardenlet.featureGates in the Helm chart values).

Which issue(s) this PR fixes:
Part of gardener/gardener#8023
Follow-up of #99

Special notes for your reviewer:
This is a preparation step needed for removing the UseGardenerNodeAgent feature gate from gardener/gardener. Without this PR, when the feature gate is removed, it's no longer available via the .Values.gardener.gardenlet.featureGates in the Helm chart. The consequence would be that --gardenlet-uses-gardener-node-agent gets set to false. This obviously does not work with versions of gardener/gardener which no longer have the UseGardenerNodeAgent feature gate.

Release note:

It is assumed that `gardenlet`'s `UseGardenerNodeAgent` is turned on by default if the feature gate is not explicitly set. Hence, make sure to use at least Gardener `v1.82` when using this extension version.

@rfranzke rfranzke requested review from a team as code owners February 23, 2024 15:01
@gardener-robot gardener-robot added area/os Operation system related kind/enhancement Enhancement, improvement, extension os/ubuntu Related to Ubuntu OS needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 23, 2024
Copy link
Contributor

@MrBatschner MrBatschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2024
@MrBatschner MrBatschner merged commit c2a87e3 into gardener:master Feb 23, 2024
5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 23, 2024
@rfranzke rfranzke deleted the gna branch February 23, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/os Operation system related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/ubuntu Related to Ubuntu OS reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants