Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let cloud-init manage /etc/hosts file #28

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Let cloud-init manage /etc/hosts file #28

merged 1 commit into from
Nov 10, 2020

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Nov 10, 2020 •
edited
Loading

How to categorize this PR?

/area os
/kind enhancement
/priority normal
/os ubuntu

What this PR does / why we need it:
The cloud-init is now managing the /etc/hosts file.

Which issue(s) this PR fixes:
Fixes #25

Special notes for your reviewer:

Release note:

The `/etc/hosts` file is now populated by cloud-init. This improvement is needed for ubuntu images where the file is not present.

@vpnachev vpnachev requested review from a team as code owners November 10, 2020 12:17
@gardener-robot gardener-robot added area/os Operation system related kind/enhancement Enhancement, improvement, extension os/ubuntu Related to Ubuntu OS priority/normal needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 10, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 10, 2020
rfranzke
rfranzke approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 10, 2020
@vpnachev vpnachev merged commit be98a97 into gardener:master Nov 10, 2020
@vpnachev vpnachev deleted the cloud-init-manage-etc-hosts branch November 10, 2020 12:51
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/os Operation system related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/ubuntu Related to Ubuntu OS reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage /etc/hosts via cloud-init
5 participants
@vpnachev @rfranzke @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot