Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart ccd service only on bootstrap #32

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Restart ccd service only on bootstrap #32

merged 2 commits into from
Jan 26, 2021

Conversation

vpnachev
Copy link
Member

How to categorize this PR?

/kind enhancement
/priority normal
/os ubuntu

What this PR does / why we need it:
Enhance the template to restart the cloud-config-downloader service only in the bootstrap config.
Vendor gardener/gardener@v1.15.5
Updates golang
Updates alpine

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Alpine has been updated to 3.12.3.

Golang has been updated to 1.15.7

Vendor gardener/gardener@v1.15.5

The `cloud-config-downloader` systemd service is enabled and restarted only in bootstrap `OperatingSystemConfigs`.

@vpnachev vpnachev requested review from a team as code owners January 23, 2021 08:16
@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension os/ubuntu Related to Ubuntu OS priority/normal needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 23, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 23, 2021
@vpnachev vpnachev mentioned this pull request Jan 23, 2021
Merged
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 23, 2021
rfranzke
rfranzke reviewed Jan 26, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 26, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 26, 2021
vlvasilev
vlvasilev approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@vlvasilev vlvasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

rfranzke
rfranzke approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vpnachev vpnachev merged commit 7ad5c4a into gardener:master Jan 26, 2021
@vpnachev vpnachev deleted the enhance-template branch January 26, 2021 09:52
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 26, 2021
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlvasilev vlvasilev vlvasilev approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees

@rfranzke rfranzke

Labels
kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/ubuntu Related to Ubuntu OS reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vpnachev @rfranzke @vlvasilev @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot