Switch bootstrap script from cloud-init to bash #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/os
gardener-robot-ci-2
added
reviewed/ok-to-test
stoyanr
approved these changes
May 18, 2021
| content: | | ||
| W1NlcnZpY2VdCkV4ZWNTdGFydD0KRXhlY1N0YXJ0PS91c3IvYmluL2NvbnRhaW5lcmQgLS1jb25maWc9L2V0Yy9jb250YWluZXJkL2NvbmZpZy50b21s | ||
| {{ end -}} | ||
| #!/bin/bash |
There was a problem hiding this comment.
I compared this file with the corresponding file in gardener-extension-os-ubuntu-alicloud and at first glance there seems to be quite a number of differences. It seems it's not immediately possible to archive the ubuntu-alicloud extension, at least not without further rework and testing. Are you aware of any major issues?
There was a problem hiding this comment.
I think the major difference is the PROVIDER_ID env variable that is already injected by the provider-alicloud.
gardener-robot
added
reviewed/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area os
/kind enhancement
/os ubuntu
What this PR does / why we need it:
Switch bootstrap script from cloud-init to bash.
Which issue(s) this PR fixes:
Fixes #31
Special notes for your reviewer:
I have tested this change and it is working fine with AWS,Azure, GCP and OpenStack.
Release note: