Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEP 10 - ContainerD Enablement #5

Merged
merged 2 commits into from
Mar 11, 2020
Merged

GEP 10 - ContainerD Enablement #5

merged 2 commits into from
Mar 11, 2020

Conversation

nimrodoron
Copy link
Contributor

@nimrodoron nimrodoron commented Feb 24, 2020 •
edited by rfranzke
Loading

Enablement of ContainerD according to GEP-10

Special notes for your reviewer:
Depends on: gardener-attic/gardener-extensions#617 + revendor

It is now supported to configure the `containerd` CRI for worker pools using the Ubuntu machine images.

@nimrodoron nimrodoron requested a review from a team as a code owner February 24, 2020 15:36
rfranzke
rfranzke reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR depends on gardener/gardener#1971 and gardener-attic/gardener-extensions#604 + revendoring, right?

Also, please squash the commits.

pkg/generator/templates/cloud-init-ubuntu.template Show resolved Hide resolved
@nimrodoron
Copy link
Contributor Author

This PR depends on gardener/gardener#1971 and gardener-attic/gardener-extensions#604 + revendoring

@nimrodoron nimrodoron requested a review from rfranzke March 8, 2020 14:39
@rfranzke rfranzke self-assigned this Mar 9, 2020
@nimrodoron nimrodoron requested a review from a team as a code owner March 11, 2020 09:09
rfranzke
rfranzke previously approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 11, 2020
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2020
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2020
@rfranzke rfranzke merged commit 9f230f5 into gardener:master Mar 11, 2020
@nimrodoron nimrodoron deleted the containerd-new-2 branch March 11, 2020 10:57
@vpnachev vpnachev mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees

@rfranzke rfranzke

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nimrodoron @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @nimrodoronsap