Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt NetworkPolicys according to recent refactorings #78

Merged
merged 6 commits into from
Mar 13, 2023
Merged

Adapt NetworkPolicys according to recent refactorings #78

merged 6 commits into from
Mar 13, 2023

Conversation

oliver-goetz
Copy link
Member

How to categorize this PR?

/area os dev-productivity ops-productivity networking security
/kind enhancement
/os ubuntu

What this PR does / why we need it:
This PR adapts the NetworkPolicys according to the recent refactorings in gardener/gardener.
See also gardener/gardener#7589 and https://github.com/gardener/gardener/blob/master/docs/concepts/resource-manager.md#networkpolicy-controller.

Which issue(s) this PR fixes:
Part of gardener/gardener#7352

Special notes for your reviewer:
/cc @rfranzke @ScheererJ @timuthy

Release note:

Adapted extension components to support the [FullNetworkPoliciesInRuntimeCluster](https://github.com/gardener/gardener/blob/master/docs/deployment/feature_gates.md#list-of-feature-gates) feature gate introduced by `gardener/gardener` v1.66, see [here](https://github.com/gardener/gardener/blob/master/docs/concepts/resource-manager.md#networkpolicy-controller) and [#7352](https://github.com/gardener/gardener/pull/7589) for more information.

@oliver-goetz oliver-goetz requested review from a team as code owners March 9, 2023 18:40
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) area/networking Networking related area/ops-productivity Operator productivity related (how to improve operations) area/os Operation system related area/security Security related kind/enhancement Enhancement, improvement, extension os/ubuntu Related to Ubuntu OS needs/review Needs review labels Mar 9, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 9, 2023
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 9, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 9, 2023
@oliver-goetz oliver-goetz mentioned this pull request Mar 9, 2023
Closed
47 tasks
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Mar 10, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 10, 2023
@oliver-goetz oliver-goetz requested a review from rfranzke March 10, 2023 12:56
rfranzke
rfranzke approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Mar 13, 2023
@gardener-robot gardener-robot removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 13, 2023
@rfranzke rfranzke merged commit 9dbba0d into gardener:master Mar 13, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 13, 2023
@oliver-goetz oliver-goetz deleted the enh/netpols branch March 13, 2023 09:20
@oliver-goetz oliver-goetz mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) area/networking Networking related area/ops-productivity Operator productivity related (how to improve operations) area/os Operation system related area/security Security related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/ubuntu Related to Ubuntu OS reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliver-goetz @rfranzke @gardener-robot-ci-1 @gardener-robot