Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert priorityclass #269

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Revert priorityclass #269

merged 2 commits into from
Jul 20, 2022

Conversation

briantopping
Copy link
Member

How to categorize this PR?

/area quality
/kind regression
/platform vsphere

What this PR does / why we need it:
Roll back PR #262.

Special notes for your reviewer:
PR is creating problems, will re-apply at a future date.

Release note:

Rollback PR #262

@briantopping
Update to vsphere CSI 2.6.0-gardener1
9c6aa30 
Signed-off-by: Brian Topping <brian.topping@sap.com>
@briantopping briantopping requested review from a team as code owners July 20, 2022 21:56
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution platform/vsphere VMware vSphere platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 20, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2022
@briantopping
Switch gardenlet to logr (7) (#6278)
00e5297 
* Switch factory to `logr`

* Switch controller setup to `logr`

* Switch lease reconciler to `logr`

* Switch extension check reconciler to `logr`

* Streamline care reconciler

* Switch seed reconciler to `logr`

* Adapt `garden.ReadGardenSecrets`

* Adapt `kutil.WaitUntilLoadBalancerIsReady`

* Adapt `dns` and `dnsrecord` extensions packages

* Adapt `seed` package

* Address PR review feedback

* Address PR review feedback
Revert "Adapt the priority according to the gardener guideline"

This reverts commit 43ab56e

Signed-off-by: Brian Topping <brian.topping@sap.com>
Prepare next Dev Cycle 0.18.0-dev
Merge pull request #407 from hendrikKahl/dep-update

Update golang version to 1.17
added .kube-secrets for "make integration-test-infra"
Update gitmodules

Signed-off-by: Brian Topping <brian.topping@sap.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2022
tuxgoose
tuxgoose approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@tuxgoose tuxgoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@briantopping briantopping merged commit fb6e0e4 into gardener:main Jul 20, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 20, 2022
@briantopping briantopping deleted the revert-priorityclass branch July 20, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxgoose tuxgoose tuxgoose approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/vsphere VMware vSphere platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@briantopping @tuxgoose @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot