Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify imageVectorOverwrite location in helm values #61

Open
Diaphteiros opened this issue Sep 15, 2022 · 0 comments
Open

unify imageVectorOverwrite location in helm values #61

Diaphteiros opened this issue Sep 15, 2022 · 0 comments
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@Diaphteiros
Copy link

As far as I have seen, the runtime-gvisor extension is the only extension where the image vector can be overwritten at .image.imageVectorOverwrite in the chart's values file. For all other extensions, the imageVectorOverwrite node is at top-level in the values file.

To make this even more confusing, this is how it is described in the values file:

image:
  repository: eu.gcr.io/gardener-project/gardener/extensions/runtime-gvisor
  tag: latest
  pullPolicy: IfNotPresent
# imageVectorOverwrite: |
...

The line with the (commented out) 'imageVectorOverwrite' is not indented and thus at the same position as it is in the example values files of the other extensions. But there, when commented in, the 'imageVectorOverwrite' must not be indented, whereas for this extension, it has to be.

It would be nice to have this unified among all extensions.

@Diaphteiros Diaphteiros added the kind/enhancement Enhancement, improvement, extension label Sep 15, 2022
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label May 25, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

2 participants