Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpa-admission-controller: Add observability and alerting #9954

Open
1 of 3 tasks
ialidzhikov opened this issue Jun 10, 2024 · 4 comments
Open
1 of 3 tasks

vpa-admission-controller: Add observability and alerting #9954

ialidzhikov opened this issue Jun 10, 2024 · 4 comments
Assignees
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension

Comments

@ialidzhikov
Copy link
Member

ialidzhikov commented Jun 10, 2024

How to categorize this issue?

/area auto-scaling
/kind enhancement

What would you like to be added:

Why is this needed:
In a recent VPA related outage (ref kubernetes/autoscaler#6884), we noticed that we are missing observability for the vpa-admission-controller component. For example:

  • we don't have a panel showing the response times of the component
  • we don't have alerts if the vpa-admission-controller response time > 10s (the webhook's timeout).
@gardener-prow gardener-prow bot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension labels Jun 10, 2024
@voelzmo
Copy link
Member

voelzmo commented Jun 10, 2024

/assign

@gardener-ci-robot
Copy link
Contributor

The Gardener project currently lacks enough active contributors to adequately respond to all issues.
This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Mark this issue as rotten with /lifecycle rotten
  • Close this issue with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2024
@voelzmo
Copy link
Member

voelzmo commented Oct 28, 2024

/remove-lifecycle stale

@gardener-prow gardener-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 28, 2024
@voelzmo
Copy link
Member

voelzmo commented Oct 28, 2024

Given we contextified the admission-controller, such that response times >10s shouldn't be catastrophic anymore, I'm nor sure if we still need the alerting. @ialidzhikov WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

3 participants